artifacts must be present in a single directory #55
Conversation
|
The second commit verifies if os and arch combination is valid. |
|
On Tue, May 03, 2016 at 01:11:14AM -0700, 梁辰晔 (Liang Chenye) wrote:
It looks like that requirement landed in de58be0 looks good to me, although of the non-Linux OSes, only |
Signed-off-by: liang chenye <[email protected]>
|
move the second commit to another PR https://github.com/opencontainers/ocitools/pull/57/files |
|
On Tue, May 03, 2016 at 05:58:19PM -0700, David Liang wrote:
“What I'm doing is just to make sure the ocitools follows spec
strictly, all the `MUST`, `Required` field should be verified.”
+1 to that. But I think that's going to bring into focus some things
in the spec that don't really make sense, so I don't want to rush
anything in without thinking it over again ;). In this case, I ended
up suggesting a larger change than I'd initially expected
(opencontainers/runtime-spec#423).
|
|
Close as invalid according to spec changes: opencontainers/runtime-spec#394 |
|
On Sun, May 15, 2016 at 11:51:42PM -0700, 梁辰晔 (Liang Chenye) wrote:
Close as invalid according to spec changes:
opencontainers/runtime-spec#394
I don't think that PR lifted the sibling requirement. And the most
recent spec release still has [1]:
This MUST include the following artifacts:
1. config.json…
2. A directory representing the root filesystem of the container…
While these artifacts MUST all be present in a single directory on
the local filesystem…
I've tried to get this restriction lifted
(opencontainers/runtime-spec#423 and opencontainers/runtime-spec#469),
but opencontainers/runtime-spec#469 was the smallest pivot I can think
of to lift the requirement, and it was rejected [2]. So unless by
some magic the runtime-spec maintainers reverse their current
position, I think we need to re-open and merge this PR.
[1]: https://github.com/opencontainers/runtime-spec/blob/v1.0.0-rc3/bundle.md
[2]: opencontainers/runtime-spec#469 (comment)
|
+1 |
3 participants
According to https://github.com/opencontainers/runtime-spec/blob/master/bundle.md,
Check if the rootfs and config file were in the same directory.
Signed-off-by: liang chenye [email protected]